Setting up Skimming Tasks - spectraTPC #5217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nzardosh
force-pushed
the
skimming
branch
2 times, most recently
from
dc2ae55 to
2007924
Compare
jgrosseo
requested changes
Jan 19, 2021
Collaborator
jgrosseo
left a comment
jgrosseo
left a comment
There was a problem hiding this comment.
Generally, we are ready to go despite my two comments below.
In addition:
- please remove the _ from the file names
- Let's also put the LFDerived.h into the SkimmingTutorials Folder (because it belongs there). This involves adding a library there and putting the dependency of the tasks to it
Contributor
Author
|
Hi @shahor02 can you please check Common/MathUtils/include/MathUtils/detail/TypeTruncation.h that was added. Let me know if you think it would benefit from any modifications (inline declaration or making the float a template etc). thanks! |
jgrosseo
approved these changes
Jan 19, 2021
shahor02
reviewed
Jan 19, 2021
| uint32_t iy; | ||
| } myu; | ||
| myu.y = x; | ||
| myu.iy &= mask; |
Collaborator
There was a problem hiding this comment.
It's OK, thought it would be safer to have a protection against touching non-fraction bits, i.e.
constexpr uint32_t ProtMask = ((0x1<<9)-1)<<23;
myu.iy &= (ProtMask|mask);
Anyway, this can be done later.
shahor02
approved these changes
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.